netdev - Re: [patch net-next] devlink: add missing unregister linecard notification

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZOcQHYAcUwd+VguS@nanopsycho>
Date: Thu, 24 Aug 2023 10:09:01 +0200
From: Jiri Pirko <jiri@...nulli.us>
To: netdev@...r.kernel.org
Cc: kuba@...nel.org, pabeni@...hat.com, davem@...emloft.net,
	edumazet@...gle.com, idosch@...dia.com, petrm@...dia.com
Subject: Re: [patch net-next] devlink: add missing unregister linecard
 notification

Kuba, do you plan to merge net into net-next any time soon? I have
another patchset depending on this.

Btw, I aimed this to net-next on purpose, in net it does not make much
sense imho.

Thanks!

Thu, Aug 17, 2023 at 02:52:40PM CEST, jiri@...nulli.us wrote:
>From: Jiri Pirko <jiri@...dia.com>
>
>Cited fixes commit introduced linecard notifications for register,
>however it didn't add them for unregister. Fix that by adding them.
>
>Fixes: c246f9b5fd61 ("devlink: add support to create line card and expose to user")
>Signed-off-by: Jiri Pirko <jiri@...dia.com>
>---
> net/devlink/leftover.c | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/net/devlink/leftover.c b/net/devlink/leftover.c
>index c26c63275b0b..e7f76cc58533 100644
>--- a/net/devlink/leftover.c
>+++ b/net/devlink/leftover.c
>@@ -6630,6 +6630,7 @@ void devlink_notify_unregister(struct devlink *devlink)
> 	struct devlink_param_item *param_item;
> 	struct devlink_trap_item *trap_item;
> 	struct devlink_port *devlink_port;
>+	struct devlink_linecard *linecard;
> 	struct devlink_rate *rate_node;
> 	struct devlink_region *region;
> 	unsigned long port_index;
>@@ -6658,6 +6659,8 @@ void devlink_notify_unregister(struct devlink *devlink)
> 
> 	xa_for_each(&devlink->ports, port_index, devlink_port)
> 		devlink_port_notify(devlink_port, DEVLINK_CMD_PORT_DEL);
>+	list_for_each_entry_reverse(linecard, &devlink->linecard_list, list)
>+		devlink_linecard_notify(linecard, DEVLINK_CMD_LINECARD_DEL);
> 	devlink_notify(devlink, DEVLINK_CMD_DEL);
> }
> 
>-- 
>2.41.0
>