netdev - Re: [PATCH net-next] selftests: bonding: delete link1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c25141405ba52eb0eee96317407376ef68802198.camel@redhat.com>
Date: Thu, 24 Aug 2023 12:31:04 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Zhengchao Shao <shaozhengchao@...wei.com>, netdev@...r.kernel.org, 
	linux-kselftest@...r.kernel.org, shuah@...nel.org
Cc: j.vosburgh@...il.com, andy@...yhouse.net, weiyongjun1@...wei.com, 
	yuehaibing@...wei.com
Subject: Re: [PATCH net-next] selftests: bonding: delete link1_1 in the
 cleanup path

On Wed, 2023-08-23 at 11:26 +0800, Zhengchao Shao wrote:
> If failed to set link1_1 to netns client, we should delete link1_1 in the
> cleanup path. But if set link1_1 to netns client successfully, delete
> link1_1 will report warning. So delete link1_1 in the cleanup path and
> drop any warning message.

I think the same could happen also for the link1_2 device.

It would probably be safer creating directly the devices in the target
namespaces, with the 'final' name

ip link add dev eth0 netns client type veth peer name eth0 netns server

Cheers,

Paolo