netdev - Re: [RFC net-next v2 1/5] net: macsec: documentation for macsec_context and macsec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <169288361453.5781.18200652512492828409@kwain>
Date: Thu, 24 Aug 2023 15:26:54 +0200
From: Antoine Tenart <atenart@...nel.org>
To: Radu Pirea (NXP OSS) <radu-nicolae.pirea@....nxp.com>, andrew@...n.ch, davem@...emloft.net, edumazet@...gle.com, hkallweit1@...il.com, kuba@...nel.org, linux@...linux.org.uk, pabeni@...hat.com, richardcochran@...il.com, sd@...asysnail.net, sebastian.tobuschat@....com
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org, Radu Pirea (NXP OSS) <radu-nicolae.pirea@....nxp.com>
Subject: Re: [RFC net-next v2 1/5] net: macsec: documentation for macsec_context and macsec_ops

Hello,

Quoting Radu Pirea (NXP OSS) (2023-08-24 11:16:11)
>  
>  /**
>   * struct macsec_context - MACsec context for hardware offloading
> + * @netdev: pointer to the netdev if the SecY is offloaded to a MAC
> + * @phydev: pointer to the phydev if the SecY is offloaded to a PHY
> + * @offload: MACsec offload status

As this selects were the offload happens and how the two previous
pointers can be accessed, might be nice to be a bit more explicit in the
comments.

> + * @secy: pointer to a MACsec SecY
> + * @rx_sc: pointer to a RX SC
> + * @assoc_num: association number of the target SA
> + * @key: key of the target SA
> + * @rx_sa: pointer to an RX SA if a RX SA is added/updated/removed
> + * @tx_sa: pointer to an TX SA if a TX SA is added/updated/removed
> + * @tx_sc_stats: pointer to TX SC stats structure
> + * @tx_sa_stats: pointer to TX SA stats structure
> + * @rx_sc_stats: pointer to TX SC stats structure

s/TX/RX/

Thanks,
Antoine