netdev - Re: [net-next PATCH v2 3/9] netdev-genl: spec: Extend netdev netlink spec in YAML for NAPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bb43b222-eddb-47ea-a36e-84415227439e@intel.com>
Date: Thu, 24 Aug 2023 15:26:37 -0700
From: "Nambiar, Amritha" <amritha.nambiar@...el.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: <netdev@...r.kernel.org>, <davem@...emloft.net>,
	<sridhar.samudrala@...el.com>
Subject: Re: [net-next PATCH v2 3/9] netdev-genl: spec: Extend netdev netlink
 spec in YAML for NAPI

On 8/23/2023 6:34 PM, Jakub Kicinski wrote:
> On Wed, 23 Aug 2023 17:46:20 -0700 Nambiar, Amritha wrote:
>> Can we have both: "queue-get" (queue object with with NAPI-ID attr) and
>> "napi-get" (NAPI object with "set of queue IDs" as an attribute),
>> something like below (rx-queue is the queue object. rx-queues is the
>> list attr within the NAPI object):
> 
> I think just queue-get is better, the IDs of queues are not unique.
> It's more of an index within a group than and identifier.
> Displaying information about e.g. XDP TX queues within would get messy.

Okay. So, I think we can support napi-get and queue-get commands as below:

--do napi-get --json='{"napi-id": 385}'
{'napi-id': 385, 'ifindex': 12, 'irq': 291, 'pid': 3614}

--do queue-get --json='{"q_index": 0, "q_type": RX}'
{'q_index': 0, 'q_type': RX, 'ifindex': 12, 'napi-id': 385}

As for queue-get, should we have a single queue object with a 'type' 
attribute for RX, TX, XDP etc. or should each of these queue types have 
their own distinct queue objects as they could have different attributes 
within.