netdev - Re: [net-next PATCH v2 3/9] netdev-genl: spec: Extend netdev netlink spec in YAML for NAPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230824165518.3002655f@kernel.org>
Date: Thu, 24 Aug 2023 16:55:18 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: "Nambiar, Amritha" <amritha.nambiar@...el.com>
Cc: <netdev@...r.kernel.org>, <davem@...emloft.net>,
 <sridhar.samudrala@...el.com>
Subject: Re: [net-next PATCH v2 3/9] netdev-genl: spec: Extend netdev
 netlink spec in YAML for NAPI

On Thu, 24 Aug 2023 15:26:37 -0700 Nambiar, Amritha wrote:
> --do queue-get --json='{"q_index": 0, "q_type": RX}'
> {'q_index': 0, 'q_type': RX, 'ifindex': 12, 'napi-id': 385}
> 
> As for queue-get, should we have a single queue object with a 'type' 
> attribute for RX, TX, XDP etc. or should each of these queue types have 
> their own distinct queue objects as they could have different attributes 
> within.

Separate objects, I think. 
The "key" for queues is a tuple of <type, id>.

e.g.

 <Rx, 0>
 <Tx, 0>
 <XDP_Tx, 0>

are 3 different objects (feel free to start with just rx and tx, 
we can add support for xdp queues later as needed).