netdev - Re: [PATCH 10/12] KEYS: encrypted: Do not include crypto/algapi.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1905e842f2f74705aa2f7d407c58171c72686cdf.camel@linux.ibm.com>
Date: Thu, 24 Aug 2023 19:57:29 -0400
From: Mimi Zohar <zohar@...ux.ibm.com>
To: Herbert Xu <herbert@...dor.apana.org.au>,
        Linux Crypto Mailing List
 <linux-crypto@...r.kernel.org>,
        Eric Biggers <ebiggers@...nel.org>, "Theodore Y. Ts'o" <tytso@....edu>,
        Jaegeuk Kim <jaegeuk@...nel.org>, linux-fscrypt@...r.kernel.org,
        Richard Weinberger <richard@....at>, linux-mtd@...ts.infradead.org,
        Marcel Holtmann <marcel@...tmann.org>,
        Johan
 Hedberg <johan.hedberg@...il.com>,
        Luiz Augusto von Dentz
 <luiz.dentz@...il.com>,
        linux-bluetooth@...r.kernel.org, Ilya Dryomov
 <idryomov@...il.com>,
        Xiubo Li <xiubli@...hat.com>, Jeff Layton
 <jlayton@...nel.org>,
        ceph-devel@...r.kernel.org,
        Steffen Klassert
 <steffen.klassert@...unet.com>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        Johannes Berg <johannes@...solutions.net>,
        linux-wireless@...r.kernel.org,
        Matthieu Baerts
 <matthieu.baerts@...sares.net>,
        Mat Martineau <martineau@...nel.org>,
        Chuck Lever <chuck.lever@...cle.com>, Neil Brown <neilb@...e.de>,
        linux-nfs@...r.kernel.org, linux-integrity@...r.kernel.org,
        "Jason A.
 Donenfeld" <Jason@...c4.com>,
        Ayush Sawal <ayush.sawal@...lsio.com>
Subject: Re: [PATCH 10/12] KEYS: encrypted: Do not include crypto/algapi.h

On Wed, 2023-08-23 at 18:32 +0800, Herbert Xu wrote:
> The header file crypto/algapi.h is for internal use only.  Use the
> header file crypto/utils.h instead.
> 
> Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>

Acked-by: Mimi Zohar <zohar@...ux.ibm.com>

> ---
> 
>  security/keys/encrypted-keys/encrypted.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/security/keys/encrypted-keys/encrypted.c b/security/keys/encrypted-keys/encrypted.c
> index 1e313982af02..8af2136069d2 100644
> --- a/security/keys/encrypted-keys/encrypted.c
> +++ b/security/keys/encrypted-keys/encrypted.c
> @@ -27,10 +27,10 @@
>  #include <linux/scatterlist.h>
>  #include <linux/ctype.h>
>  #include <crypto/aes.h>
> -#include <crypto/algapi.h>
>  #include <crypto/hash.h>
>  #include <crypto/sha2.h>
>  #include <crypto/skcipher.h>
> +#include <crypto/utils.h>
>  
>  #include "encrypted.h"
>  #include "ecryptfs_format.h"