netdev - Re: [PATCH net-next v2 0/4] selftests/tc-testing: add tests covering classid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b5146739-debb-4c55-820c-55a28478f9d8@mojatatu.com>
Date: Fri, 25 Aug 2023 18:03:27 -0300
From: Victor Nogueira <victor@...atatu.com>
To: Pedro Tammela <pctammela@...atatu.com>, netdev@...r.kernel.org
Cc: jhs@...atatu.com, xiyou.wangcong@...il.com, jiri@...nulli.us,
 davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 pabeni@...hat.com, shuah@...nel.org, victor@...atatu.com
Subject: Re: [PATCH net-next v2 0/4] selftests/tc-testing: add tests covering
 classid

On 25/08/2023 12:51, Pedro Tammela wrote:
> Patches 1-3 add missing tests covering classid behaviour on tdc for cls_fw,
> cls_route and cls_fw. This behaviour was recently fixed by valis[0].
> 
> Patch 4 comes from the development done in the previous patches as it turns out
> cls_route never returns meaningful errors.
> 
> [0] https://lore.kernel.org/all/20230729123202.72406-1-jhs@mojatatu.com/
> 
> v1->v2: https://lore.kernel.org/all/20230818163544.351104-1-pctammela@mojatatu.com/
>     - Drop u32 updates
> 
> Pedro Tammela (4):
>    selftests/tc-testing: cls_fw: add tests for classid
>    selftest/tc-testing: cls_route: add tests for classid
>    selftest/tc-testing: cls_u32: add tests for classid
>    net/sched: cls_route: make netlink errors meaningful
> 
>   net/sched/cls_route.c                         | 27 +++++-----
>   .../tc-testing/tc-tests/filters/fw.json       | 49 +++++++++++++++++++
>   .../tc-testing/tc-tests/filters/route.json    | 25 ++++++++++
>   .../tc-testing/tc-tests/filters/u32.json      | 25 ++++++++++
>   4 files changed, 114 insertions(+), 12 deletions(-)
> 


For the series,

Reviewed-by: Victor Nogueira <victor@...atatu.com>