netdev - Re: [PATCH v2 iproute2-next 1/2] tc: support the netem seed parameter for loss and corruption events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 30 Aug 2023 14:30:42 +0200
From: François Michel <francois.michel@...ouvain.be>
To: Petr Machata <petrm@...dia.com>
Cc: netdev@...r.kernel.org, stephen@...workplumber.org
Subject: Re: [PATCH v2 iproute2-next 1/2] tc: support the netem seed parameter
 for loss and corruption events

Hi,

Le 29/08/23 à 12:07, Petr Machata a écrit :
> Took me a while to fight my way through all the unreads to this, and
> it's already merged, but...
> 
> francois.michel@...ouvain.be writes:
> 
>> diff --git a/tc/q_netem.c b/tc/q_netem.c
>> index 8ace2b61..febddd49 100644
>> --- a/tc/q_netem.c
>> +++ b/tc/q_netem.c
>> @@ -31,6 +31,7 @@ static void explain(void)
>>   		"                 [ loss random PERCENT [CORRELATION]]\n"
>>   		"                 [ loss state P13 [P31 [P32 [P23 P14]]]\n"
>>   		"                 [ loss gemodel PERCENT [R [1-H [1-K]]]\n"
>> +		"                 [ seed SEED \n]"
> 
> The newline seems misplaced.

Sorry for that, I don't know how I could have missed that.
Should I send a patch to fix this ?

François
> 
>>   		"                 [ ecn ]\n"
>>   		"                 [ reorder PERCENT [CORRELATION] [ gap DISTANCE ]]\n"
>>   		"                 [ rate RATE [PACKETOVERHEAD] [CELLSIZE] [CELLOVERHEAD]]\n"