netdev - Re: [PATCH iproute2-next 1/1] tc: fix typo in netem's usage string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m2pm33eg4k.fsf@gmail.com>
Date: Thu, 31 Aug 2023 10:05:31 +0100
From: Donald Hunter <donald.hunter@...il.com>
To: Petr Machata <petrm@...dia.com>
Cc: <francois.michel@...ouvain.be>,  <netdev@...r.kernel.org>,
  <stephen@...workplumber.org>,  <dsahern@...nel.org>
Subject: Re: [PATCH iproute2-next 1/1] tc: fix typo in netem's usage string

Petr Machata <petrm@...dia.com> writes:

> francois.michel@...ouvain.be writes:
>
>> From: François Michel <francois.michel@...ouvain.be>
>>
>> Signed-off-by: François Michel <francois.michel@...ouvain.be>
>
> Reviewed-by: Petr Machata <petrm@...dia.com>
>
> That said...
>
>>  		"                 [ loss state P13 [P31 [P32 [P23 P14]]]\n"
>>  		"                 [ loss gemodel PERCENT [R [1-H [1-K]]]\n"
>
> ... and sorry for piling on like this, but since we are in the domain of
> fixing netem typos, if you would also fix the missing brackets on these
> two lines, that would be awesome.

The tc-netem(8) man page suggests (and usage confirms) that P14 is also
an optional parameter so it should be bracketed as well.

https://www.man7.org/linux/man-pages/man8/tc-netem.8.html