netdev - Re: [PATCH iproute2-next 1/1] tc: fix typo in netem's usage string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6897e76b-546f-6c56-36ab-46f97555e922@uclouvain.be>
Date: Thu, 31 Aug 2023 11:12:12 +0200
From: François Michel <francois.michel@...ouvain.be>
To: Donald Hunter <donald.hunter@...il.com>, Petr Machata <petrm@...dia.com>
Cc: netdev@...r.kernel.org, stephen@...workplumber.org, dsahern@...nel.org
Subject: Re: [PATCH iproute2-next 1/1] tc: fix typo in netem's usage string

Hi,

Le 31/08/23 à 11:05, Donald Hunter a écrit :
> Petr Machata <petrm@...dia.com> writes:
> 
>> francois.michel@...ouvain.be writes:
>>
>>> From: François Michel <francois.michel@...ouvain.be>
>>>
>>> Signed-off-by: François Michel <francois.michel@...ouvain.be>
>>
>> Reviewed-by: Petr Machata <petrm@...dia.com>
>>
>> That said...
>>
>>>   		"                 [ loss state P13 [P31 [P32 [P23 P14]]]\n"
>>>   		"                 [ loss gemodel PERCENT [R [1-H [1-K]]]\n"
>>
>> ... and sorry for piling on like this, but since we are in the domain of
>> fixing netem typos, if you would also fix the missing brackets on these
>> two lines, that would be awesome.
> 
> The tc-netem(8) man page suggests (and usage confirms) that P14 is also
> an optional parameter so it should be bracketed as well.

Allright. While we're at it, I'll will also probably unify the spaces 
around brackets. On other qdiscs, brackets seem to be systematically 
surrounded by spaces.

François

> 
> https://www.man7.org/linux/man-pages/man8/tc-netem.8.html