netdev - Re: [PATCH net-next] veth: Fixing transmit return status for dropped packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANn89i+9GBoL-xDMwv6fBzCju9DxA-1LMk-5Errj7tA0Xoyo1A@mail.gmail.com>
Date: Thu, 31 Aug 2023 11:24:30 +0200
From: Eric Dumazet <edumazet@...gle.com>
To: Liang Chen <liangchen.linux@...il.com>
Cc: davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com, 
	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] veth: Fixing transmit return status for dropped packets

On Thu, Aug 31, 2023 at 11:06 AM Liang Chen <liangchen.linux@...il.com> wrote:
>
> The veth_xmit function returns NETDEV_TX_OK even when packets are dropped.
> This behavior leads to incorrect calculations of statistics counts, as
> well as things like txq->trans_start updates.
>
> Signed-off-by: Liang Chen <liangchen.linux@...il.com>
> ---

We kindly ask for net patches to include a Fixes: tag.

If we receive hundreds of patches without them, it takes hours of work
for reviewers
to do the _needed_ work.

We need your help.

Fixes: e314dbdc1c0d ("[NET]: Virtual ethernet device driver.")

Reviewed-by: Eric Dumazet <edumazet@...gle.com>

Thanks.