netdev - Re: [PATCH 1/4] net: dsa: Extend the dsa_switch structure to hold info about HSR ports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230831112915.5b114379@wsk>
Date: Thu, 31 Aug 2023 11:29:15 +0200
From: Lukasz Majewski <lukma@...x.de>
To: Paolo Abeni <pabeni@...hat.com>
Cc: Tristram.Ha@...rochip.com, Eric Dumazet  <edumazet@...gle.com>,
 davem@...emloft.net, Woojung Huh  <woojung.huh@...rochip.com>, Vladimir
 Oltean <olteanv@...il.com>, Andrew Lunn <andrew@...n.ch>, Florian Fainelli
 <f.fainelli@...il.com>, Jakub Kicinski  <kuba@...nel.org>,
 UNGLinuxDriver@...rochip.com, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] net: dsa: Extend the dsa_switch structure to hold
 info about HSR ports

Hi Paolo,

> On Tue, 2023-08-29 at 14:11 +0200, Lukasz Majewski wrote:
> > Information about HSR aware ports in a DSA switch can be helpful
> > when one needs tags to be adjusted before the HSR frame is sent.
> > 
> > For example - with ksz9477 switch - the TAG needs to be adjusted to
> > have both HSR ports marked in tag to allow execution of HW based
> > frame duplication.
> > 
> > Signed-off-by: Lukasz Majewski <lukma@...x.de>
> > ---
> >  include/net/dsa.h | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/include/net/dsa.h b/include/net/dsa.h
> > index d309ee7ed04b..15274afc42bb 100644
> > --- a/include/net/dsa.h
> > +++ b/include/net/dsa.h
> > @@ -470,6 +470,9 @@ struct dsa_switch {
> >  	/* Number of switch port queues */
> >  	unsigned int		num_tx_queues;
> >  
> > +	/* Bitmask indicating ports supporting HSR */
> > +	u16                     hsr_ports;
> > +
> >  	/* Drivers that benefit from having an ID associated with
> > each
> >  	 * offloaded LAG should set this to the maximum number of
> >  	 * supported IDs. DSA will then maintain a mapping of _at  
> 
> Out of sheer ignorance, I think this new field does not belong to
> dsa_switch, at least not in this form. AFAICS there is no current hard
> limitation on the number of ports a DSA switch can handle at the API
> level, and this will introduce an hard one.
> 
> I think you are better off keeping this field in the KSZ-specific
> struct.

That was mine first idea - to move it to struct ksz_device from
./drivers/net/dsa/ksz_common.h

However, this file and this struct is not easily accessible from
net/dsa/tag_ksz.c

One idea was to use an exported function - e.g. ksz_get_hsr_ports() and
in it I would read the hsr_ports member ?

Another option would be to loop through all switch ports with
hsr_for_each_port(), but this would affect overall network performance.

> If you really want to keep it here you should remove the above
> limitation somehow (possibly a query op to check if a given port is
> HSR aware???)

I will use the idea of exported helper function to get HSR members
ports.

> 
> In any case this series looks like net-next material, does not apply
> correctly to net-next and net-next is currently closed. You can share
> a new version as RFC or wait for net-next to re-open in ~2w.
> 

I will prepare v2 and then adjust it to net-next when required.

> Cheers,
> 
> Paolo
> 




Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@...x.de

Content of type "application/pgp-signature" skipped