netdev - Re: [PATCH net-next] net: bcmasp: Do not check for 0 return after calling platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230901140202.GI140739@kernel.org>
Date: Fri, 1 Sep 2023 16:02:02 +0200
From: Simon Horman <horms@...nel.org>
To: Jinjie Ruan <ruanjinjie@...wei.com>
Cc: bcm-kernel-feedback-list@...adcom.com, netdev@...r.kernel.org,
	Justin Chen <justin.chen@...adcom.com>,
	Florian Fainelli <florian.fainelli@...adcom.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net-next] net: bcmasp: Do not check for 0 return after
 calling platform_get_irq()

On Fri, Sep 01, 2023 at 03:04:43PM +0800, Jinjie Ruan wrote:
> It is not possible for platform_get_irq() to return 0. And it return
> -EINVAL when the irq = 0 and -ENXIO when the irq can not be found. The
> best practice is to return the err code from platform_get_irq().
> 
> Fixes: 490cb412007d ("net: bcmasp: Add support for ASP2.0 Ethernet controller")

Hi Jinjie Ruan,

This seems more like a cleanup than a fix, I think the tag should be dropped.

> Signed-off-by: Jinjie Ruan <ruanjinjie@...wei.com>

## Form letter - net-next-closed

The merge window for v6.6 has begun and therefore net-next is closed
for new drivers, features, code refactoring and optimizations.
We are currently accepting bug fixes only.

Please repost when net-next reopens after Sept 11th.

RFC patches sent for review only are obviously welcome at any time.

See: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#development-cycle
--
pw-bot: defer