netdev - Re: [PATCH] r8169: Disable multicast filter for RTL_GIGA_MAC_VER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJs+hrGmHF4EHsYGVPCosSNOE075CzTsP1d9hppMNXAB1n=JAw@mail.gmail.com>
Date: Fri, 1 Sep 2023 10:20:08 -0400
From: Patrick Thompson <ptf@...gle.com>
To: Heiner Kallweit <hkallweit1@...il.com>
Cc: Jakub Kicinski <kuba@...nel.org>, LKML <linux-kernel@...r.kernel.org>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org, nic_swsd@...ltek.com, 
	Chun-Hao Lin <hau@...ltek.com>
Subject: Re: [PATCH] r8169: Disable multicast filter for RTL_GIGA_MAC_VER_46

Okay sounds good. By the way, here's the patch where the VER_35 logic
was added. So one question would be are there more chips without
multicast hardware filters?
------------------

From: Nathan Walp <faceprint@...xxxxxxxxxx>

commit 0481776b7a70f09acf7d9d97c288c3a8403fbfe4 upstream.

RTL_GIGA_MAC_VER_35 includes no multicast hardware filter.

Signed-off-by: Nathan Walp <faceprint@...xxxxxxxxxx>
Suggested-by: Hayes Wang <hayeswang@...xxxxxxxx>
Acked-by: Francois Romieu <romieu@...xxxxxxxxxx>
Signed-off-by: David S. Miller <davem@...xxxxxxxxxx>
Signed-off-by: Herton Ronaldo Krzesinski <herton.krzesinski@...xxxxxxxxxx>
---
drivers/net/ethernet/realtek/r8169.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/net/ethernet/realtek/r8169.c
b/drivers/net/ethernet/realtek/r8169.c
index eb81da4..e19e1f1 100644
--- a/drivers/net/ethernet/realtek/r8169.c
+++ b/drivers/net/ethernet/realtek/r8169.c
@@ -4271,6 +4271,9 @@ static void rtl_set_rx_mode(struct net_device *dev)
mc_filter[1] = swab32(data);
}

+ if (tp->mac_version == RTL_GIGA_MAC_VER_35)
+ mc_filter[1] = mc_filter[0] = 0xffffffff;
+
RTL_W32(MAR0 + 4, mc_filter[1]);
RTL_W32(MAR0 + 0, mc_filter[0]);

--
1.7.9.5

--

On Fri, Sep 1, 2023 at 8:48 AM Heiner Kallweit <hkallweit1@...il.com> wrote:
>
> On 01.09.2023 14:28, Patrick Thompson wrote:
> > Hello,
> >
> > I was wondering if this should be extended to all RTL_GIGA_MAC_VERs
> > greater than 35 as well.
> >
> I *think* the mc filtering issue with version 35 is different from the
> one you're seeing. So not every chip version may be affected.
> As there's no public errata information let's wait for a statement
> from Realtek.
>
> > Realtek responded to me but I was slow to get them packet captures
> > that they needed. I am hoping to restart things and get back to this
> > over the finish line if it's a valid patch.
> >
> > I will add the appropriate tags and annotations once I hear back.
> >
> > On Tue, Jun 6, 2023 at 5:29 PM Jakub Kicinski <kuba@...nel.org> wrote:
> >>
> >> On Tue, 6 Jun 2023 17:11:27 +0200 Heiner Kallweit wrote:
> >>> Thanks for the report and the patch. I just asked a contact in Realtek
> >>> whether more chip versions may be affected. Then the patch should be
> >>> extended accordingly. Let's wait few days for a response.
> >>>
> >>> I think we should make this a fix. Add the following as Fixes tag
> >>> and annotate the patch as "net" (see netdev FAQ).
> >>>
> >>> 6e1d0b898818 ("r8169:add support for RTL8168H and RTL8107E")
> >>
> >> Perhaps it's best if you repost with the Fixes tag included once
> >> Realtek responded.
>