netdev - Re: [PATCH net] sfc: check for zero length in EF10 RX prefix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <11386.1693600107@famine>
Date: Fri, 01 Sep 2023 13:28:27 -0700
From: Jay Vosburgh <jay.vosburgh@...onical.com>
To: patchwork-bot+netdevbpf@...nel.org
cc: edward.cree@....com, linux-net-drivers@....com, davem@...emloft.net,
    kuba@...nel.org, edumazet@...gle.com, pabeni@...hat.com,
    ecree.xilinx@...il.com, netdev@...r.kernel.org,
    habetsm.xilinx@...il.com
Subject: Re: [PATCH net] sfc: check for zero length in EF10 RX prefix

patchwork-bot+netdevbpf@...nel.org wrote:

>Hello:
>
>This patch was applied to netdev/net.git (main)
>by David S. Miller <davem@...emloft.net>:
>
>On Thu, 31 Aug 2023 17:58:11 +0100 you wrote:
>> From: Edward Cree <ecree.xilinx@...il.com>
>> 
>> When EF10 RXDP firmware is operating in cut-through mode, packet length
>>  is not known at the time the RX prefix is generated, so it is left as
>>  zero and RX event merging is inhibited to ensure that the length is
>>  available in the RX event.  However, it has been found that in certain
>>  circumstances the RX events for these packets still get merged,
>>  meaning the driver cannot read the length from the RX event, and tries
>>  to use the length from the prefix.
>> The resulting zero-length SKBs cause crashes in GRO since commit
>>  1d11fa696733 ("net-gro: remove GRO_DROP"), so add a check to the driver
>>  to detect these zero-length RX events and discard the packet.
>> 
>> [...]

	Should this have included

Fixes: 1d11fa696733 ("net-gro: remove GRO_DROP")

	to queue the patch for -stable?  We have users running into this
issue on 5.15 series kernels.

	-J

---
	-Jay Vosburgh, jay.vosburgh@...onical.com