netdev - Re: [PATCH net] sfc: check for zero length in EF10 RX prefix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <29b21a45-a391-9e33-5c6a-78cba2231512@gmail.com>
Date: Mon, 4 Sep 2023 09:41:38 +0100
From: Edward Cree <ecree.xilinx@...il.com>
To: Jay Vosburgh <jay.vosburgh@...onical.com>
Cc: edward.cree@....com, linux-net-drivers@....com, netdev@...r.kernel.org,
 habetsm.xilinx@...il.com
Subject: Re: [PATCH net] sfc: check for zero length in EF10 RX prefix

On 01/09/2023 21:28, Jay Vosburgh wrote:
>>> The resulting zero-length SKBs cause crashes in GRO since commit
>>>  1d11fa696733 ("net-gro: remove GRO_DROP"), so add a check to the driver
>>>  to detect these zero-length RX events and discard the packet.
>>>
>>> [...]
> 
> 	Should this have included
> 
> Fixes: 1d11fa696733 ("net-gro: remove GRO_DROP")
> 
> 	to queue the patch for -stable?  We have users running into this
> issue on 5.15 series kernels.

I didn't think Fixes: was appropriate (for various abstruse reasons I
 won't go into), but this does want to go to -stable.  I expect Sasha's
 robot will select it, but feel free to submit it explicitly.

-ed