netdev - Re: [PATCH v1 net 3/4] af_unix: Fix data-races around sk->sk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89i+vJ-0zbGHRhWUKys1K3_D36y0jrHm=X5zY=qxuRZ-SoA@mail.gmail.com>
Date: Sat, 2 Sep 2023 08:43:11 +0200
From: Eric Dumazet <edumazet@...gle.com>
To: Kuniyuki Iwashima <kuniyu@...zon.com>
Cc: "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, Kuniyuki Iwashima <kuni1840@...il.com>, netdev@...r.kernel.org, 
	syzkaller <syzkaller@...glegroups.com>
Subject: Re: [PATCH v1 net 3/4] af_unix: Fix data-races around sk->sk_shutdown.

On Sat, Sep 2, 2023 at 2:28 AM Kuniyuki Iwashima <kuniyu@...zon.com> wrote:
>
> sk->sk_shutdown is changed under unix_state_lock(sk), but
> unix_dgram_sendmsg() calls two functions to read sk_shutdown locklessly.
>
>   sock_alloc_send_pskb
>   `- sock_wait_for_wmem
>
> Let's use READ_ONCE() there.
>
> Note that the writer side was marked by commit e1d09c2c2f57 ("af_unix:
> Fix data races around sk->sk_shutdown.").
>
> BUG: KCSAN: data-race in sock_alloc_send_pskb / unix_release_sock
>
>
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Reported-by: syzkaller <syzkaller@...glegroups.com>
> Signed-off-by: Kuniyuki Iwashima <kuniyu@...zon.com>

Reviewed-by: Eric Dumazet <edumazet@...gle.com>