netdev - Re: [PATCH v1 net 4/4] af_unix: Fix data race around sk->sk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iJnbUT4SxkU2Mm9SrxaUSGHojXUqaBwSxr=fUG9wbacNw@mail.gmail.com>
Date: Sat, 2 Sep 2023 08:45:12 +0200
From: Eric Dumazet <edumazet@...gle.com>
To: Kuniyuki Iwashima <kuniyu@...zon.com>
Cc: "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, Kuniyuki Iwashima <kuni1840@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH v1 net 4/4] af_unix: Fix data race around sk->sk_err.

On Sat, Sep 2, 2023 at 2:29 AM Kuniyuki Iwashima <kuniyu@...zon.com> wrote:
>
> As with sk->sk_shutdown shown in the previous patch, sk->sk_err can be
> read locklessly by unix_dgram_sendmsg().
>
> Let's use READ_ONCE() for sk_err as well.
>
> Note that the writer side is marked by commit cc04410af7de ("af_unix:
> annotate lockless accesses to sk->sk_err").
>
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Signed-off-by: Kuniyuki Iwashima <kuniyu@...zon.com>
> ---

Title is slightly off, since this is a generic net: change, but this
is fine really ;)

Reviewed-by: Eric Dumazet <edumazet@...gle.com>

Thanks.