netdev - Re: [bug report] net: enetc: reimplement RFS/RSS memory clearing as PCI quirk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230906141652.a4dschg2jbobzcoj@skbuf>
Date: Wed, 6 Sep 2023 17:16:52 +0300
From: Vladimir Oltean <vladimir.oltean@....com>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: netdev@...r.kernel.org
Subject: Re: [bug report] net: enetc: reimplement RFS/RSS memory clearing as
 PCI quirk

On Wed, Sep 06, 2023 at 02:48:20PM +0300, Dan Carpenter wrote:
> Hello Vladimir Oltean,
> 
> The patch f0168042a212: "net: enetc: reimplement RFS/RSS memory
> clearing as PCI quirk" from Aug 3, 2023 (linux-next), leads to the
> following Smatch static checker warning:
> 
> 	drivers/net/ethernet/freescale/enetc/enetc_pf.c:1405 enetc_fixup_clear_rss_rfs()
> 	warn: 'si' is an error pointer or valid
> 
> drivers/net/ethernet/freescale/enetc/enetc_pf.c
>     1393 static void enetc_fixup_clear_rss_rfs(struct pci_dev *pdev)
>     1394 {
>     1395         struct device_node *node = pdev->dev.of_node;
>     1396         struct enetc_si *si;
>     1397 
>     1398         /* Only apply quirk for disabled functions. For the ones
>     1399          * that are enabled, enetc_pf_probe() will apply it.
>     1400          */
>     1401         if (node && of_device_is_available(node))
>     1402                 return;
>     1403 
>     1404         si = enetc_psi_create(pdev);
> --> 1405         if (si)
> 
> I guess this should be if (!IS_ERR(si)) {?
> 
>     1406                 enetc_psi_destroy(pdev);
>     1407 }
> 
> regards,
> dan carpenter

Thanks. I've submitted a patch based on this suggestion
(Message-ID: 20230906141609.247579-1-vladimir.oltean@....com).