netdev - Re: [PATCH net] net: phylink: fix sphinx complaint about invalid literal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 6 Sep 2023 13:34:08 +0700
From: Bagas Sanjaya <bagasdotme@...il.com>
To: Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net
Cc: netdev@...r.kernel.org, edumazet@...gle.com, pabeni@...hat.com,
	Stephen Rothwell <sfr@...b.auug.org.au>, linux@...linux.org.uk,
	rmk+kernel@...linux.org.uk
Subject: Re: [PATCH net] net: phylink: fix sphinx complaint about invalid
 literal

On Tue, Sep 05, 2023 at 04:42:02PM -0700, Jakub Kicinski wrote:
> diff --git a/include/linux/phylink.h b/include/linux/phylink.h
> index 7d07f8736431..2b886ea654bb 100644
> --- a/include/linux/phylink.h
> +++ b/include/linux/phylink.h
> @@ -600,7 +600,7 @@ void pcs_get_state(struct phylink_pcs *pcs,
>   *
>   * The %neg_mode argument should be tested via the phylink_mode_*() family of
>   * functions, or for PCS that set pcs->neg_mode true, should be tested
> - * against the %PHYLINK_PCS_NEG_* definitions.
> + * against the PHYLINK_PCS_NEG_* definitions.
>   */
>  int pcs_config(struct phylink_pcs *pcs, unsigned int neg_mode,
>  	       phy_interface_t interface, const unsigned long *advertising,
> @@ -630,7 +630,7 @@ void pcs_an_restart(struct phylink_pcs *pcs);
>   *
>   * The %mode argument should be tested via the phylink_mode_*() family of
>   * functions, or for PCS that set pcs->neg_mode true, should be tested
> - * against the %PHYLINK_PCS_NEG_* definitions.
> + * against the PHYLINK_PCS_NEG_* definitions.
>   */
>  void pcs_link_up(struct phylink_pcs *pcs, unsigned int neg_mode,
>  		 phy_interface_t interface, int speed, int duplex);

The fix LGTM, thanks!

Reviewed-by: Bagas Sanjaya <bagasdotme@...il.com>

-- 
An old man doll... just what I always wanted! - Clara

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)