netdev - Re: [PATCH net-next] net: microchip: sparx5: clean up error checking in vcap_show

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230908082723.rcpkr7bagcptt3he@DEN-LT-70577>
Date: Fri, 8 Sep 2023 08:27:23 +0000
From: Daniel Machon <daniel.machon@...rochip.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
CC: Lars Povlsen <lars.povlsen@...rochip.com>, Horatiu Vultur
	<horatiu.vultur@...rochip.com>, Steen Hegelund
	<Steen.Hegelund@...rochip.com>, <UNGLinuxDriver@...rochip.com>, "David S.
 Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, "Jakub
 Kicinski" <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	<netdev@...r.kernel.org>, <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH net-next] net: microchip: sparx5: clean up error checking
 in vcap_show_admin()

> The vcap_decode_rule() never returns NULL.  There is no need to check
> for that.  This code assumes that if it did return NULL we should
> end abruptly and return success.  It is confusing.  Fix the check to
> just be if (IS_ERR()) instead of if (IS_ERR_OR_NULL()).
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/r/202309070831.hTvj9ekP-lkp@intel.com/
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> ---
> This bug is old, but it doesn't affect runtime so it should go to
> net-next.
> 

LGTM.

Thanks Dan!

Reviewed-by: Daniel Machon <daniel.machon@...rochip.com>