netdev - Re: [PATCH net-next] net: microchip: sparx5: clean up error checking in vcap_show

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <169634282481.20237.11023023965900224021.git-patchwork-notify@kernel.org>
Date: Tue, 03 Oct 2023 14:20:24 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: lars.povlsen@...rochip.com, horatiu.vultur@...rochip.com,
 Steen.Hegelund@...rochip.com, daniel.machon@...rochip.com,
 UNGLinuxDriver@...rochip.com, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, netdev@...r.kernel.org,
 kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net-next] net: microchip: sparx5: clean up error checking in
 vcap_show_admin()

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Fri, 8 Sep 2023 10:03:37 +0300 you wrote:
> The vcap_decode_rule() never returns NULL.  There is no need to check
> for that.  This code assumes that if it did return NULL we should
> end abruptly and return success.  It is confusing.  Fix the check to
> just be if (IS_ERR()) instead of if (IS_ERR_OR_NULL()).
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/r/202309070831.hTvj9ekP-lkp@intel.com/
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> 
> [...]

Here is the summary with links:
  - [net-next] net: microchip: sparx5: clean up error checking in vcap_show_admin()
    https://git.kernel.org/netdev/net-next/c/788f63c4dc17

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html