netdev - Re: [PATCH net] fix null-deref in ipv4_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a49df474-fbe8-6581-8102-f4c4b89d4ed3@kernel.org>
Date: Tue, 12 Sep 2023 09:58:44 -0600
From: David Ahern <dsahern@...nel.org>
To: Kyle Zeng <zengyhkyle@...il.com>, pabeni@...hat.com
Cc: vfedorenko@...ek.ru, davem@...emloft.net, netdev@...r.kernel.org,
 ssuryaextr@...il.com
Subject: Re: [PATCH net] fix null-deref in ipv4_link_failure

On 9/11/23 8:35 PM, Kyle Zeng wrote:
> Currently, we assume the skb is associated with a device before calling
> __ip_options_compile, which is not always the case if it is re-routed by
> ipvs.
> When skb->dev is NULL, dev_net(skb->dev) will become null-dereference.
> This patch adds a check for the edge case and switch to use the net_device
> from the rtable when skb->dev is NULL.
> 
> Fixes: ed0de45 ("ipv4: recompile ip options in ipv4_link_failure")
> Suggested-by: David Ahern <dsahern@...nel.org>
> Signed-off-by: Kyle Zeng <zengyhkyle@...il.com>
> Cc: Stephen Suryaputra <ssuryaextr@...il.com>
> Cc: Vadim Fedorenko <vfedorenko@...ek.ru>
> ---
>  net/ipv4/route.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 

Reviewed-by: David Ahern <dsahern@...nel.org>