lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <ec738a108981c42604fa50f89c4551942b9e281b.camel@redhat.com> Date: Thu, 14 Sep 2023 11:17:40 +0200 From: Paolo Abeni <pabeni@...hat.com> To: Kyle Zeng <zengyhkyle@...il.com>, dsahern@...nel.org Cc: vfedorenko@...ek.ru, davem@...emloft.net, netdev@...r.kernel.org, ssuryaextr@...il.com Subject: Re: [PATCH net] fix null-deref in ipv4_link_failure On Mon, 2023-09-11 at 19:35 -0700, Kyle Zeng wrote: > Currently, we assume the skb is associated with a device before calling > __ip_options_compile, which is not always the case if it is re-routed by > ipvs. > When skb->dev is NULL, dev_net(skb->dev) will become null-dereference. > This patch adds a check for the edge case and switch to use the net_device > from the rtable when skb->dev is NULL. > > Fixes: ed0de45 ("ipv4: recompile ip options in ipv4_link_failure") I'm sorry for the nit-picking, but please use 12 chars to identify the blamed commit or we risk (future) conflicts. Please also add a subsystem tag inside the subj. Finally include a revision counter into prefix, alike: [PATCH v3 net] ipv4: fix ... (I'm not really sure about the correct counter here, since a few versions flied without it) Note that you can retain David's ack in the next revision. Thanks! Paolo
Powered by blists - more mailing lists