netdev - Re: [PATCH net-next v2 1/3] ptp: Replace timestamp event queue with linked list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZQMW222Lu0BwkhGr@hoboy.vegasvil.org>
Date: Thu, 14 Sep 2023 07:21:15 -0700
From: Richard Cochran <richardcochran@...il.com>
To: Xabier Marquiegui <reibax@...il.com>
Cc: netdev@...r.kernel.org, horms@...nel.org,
	chrony-dev@...ony.tuxfamily.org, mlichvar@...hat.com,
	ntp-lists@...tcorallo.com, shuah@...nel.org, davem@...emloft.net,
	rrameshbabu@...dia.com, alex.maftei@....com
Subject: Re: [PATCH net-next v2 1/3] ptp: Replace timestamp event queue with
 linked list

On Wed, Sep 13, 2023 at 12:02:15AM +0200, Xabier Marquiegui wrote:
> This is the first of a set of patches to introduce linked lists to the
> timestamp event queue. The final goal is to be able to have multiple
> readers for the timestamp queue.
> 
> On this one we maintain the original feature set, and we just introduce
> the linked lists to the data structure.
> 
> Signed-off-by: Xabier Marquiegui <reibax@...il.com>
> Suggested-by: Richard Cochran <richardcochran@...il.com>
> ---
> v2:
>   - Style changes to comform to checkpatch strict suggestions
> v1: https://lore.kernel.org/netdev/20230906104754.1324412-2-reibax@gmail.com/

Overall this is much improved.  Still as Vinicius pointed out, there
are a couple of issues to be addressed:

- open file tracking
- list handling

Thanks,
Richard