lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CANn89i+AtUw1i7VC_POoC6Y+KGXDM7AnV6RitpRPjyUNrtE1Kg@mail.gmail.com> Date: Thu, 14 Sep 2023 16:16:53 +0200 From: Eric Dumazet <edumazet@...gle.com> To: Yuchung Cheng <ycheng@...gle.com> Cc: Paolo Abeni <pabeni@...hat.com>, Aananth V <aananthv@...gle.com>, David Miller <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org, Neal Cardwell <ncardwell@...gle.com> Subject: Re: [PATCH net-next 2/2] tcp: new TCP_INFO stats for RTO events On Thu, Sep 14, 2023 at 3:37 PM Yuchung Cheng <ycheng@...gle.com> wrote: > > On Thu, Sep 14, 2023 at 5:02 AM Paolo Abeni <pabeni@...hat.com> wrote: > > > > Hi, > > > > On Tue, 2023-09-12 at 02:33 +0000, Aananth V wrote: > > > @@ -2825,6 +2829,14 @@ void tcp_enter_recovery(struct sock *sk, bool ece_ack) > > > tcp_set_ca_state(sk, TCP_CA_Recovery); > > > } > > > > > > +static inline void tcp_update_rto_time(struct tcp_sock *tp) > > > +{ > > > + if (tp->rto_stamp) { > > > + tp->total_rto_time += tcp_time_stamp(tp) - tp->rto_stamp; > > > + tp->rto_stamp = 0; > > > + } > > > +} > > > > The CI is complaining about 'inline' function in .c file. I guess that > > is not by accident and the goal is to maximize fast-path performances? > > > > Perhaps worthy moving the function to an header file to make static > > checkers happy? > > or simply remove the inline keyword since it's only used in that file. Yes, these inline are not really needed, the compiler will generate the same code.
Powered by blists - more mailing lists