lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <uzvjph54kg2jkfbmwrvmunqv64ig7j6szr6pxxbiesnz5lletg@zq57w7jj2up4> Date: Thu, 14 Sep 2023 20:05:09 +0300 From: Serge Semin <fancer.lancer@...il.com> To: Jose Abreu <Jose.Abreu@...opsys.com>, Russell King <linux@...linux.org.uk>, Serge Semin <fancer.lancer@...il.com> Cc: Russell King <linux@...linux.org.uk>, Jakub Kicinski <kuba@...nel.org>, Alexandre Torgue <alexandre.torgue@...s.st.com>, Alexei Starovoitov <ast@...nel.org>, "bpf@...r.kernel.org" <bpf@...r.kernel.org>, Daniel Borkmann <daniel@...earbox.net>, "David S. Miller" <davem@...emloft.net>, Emil Renner Berthing <kernel@...il.dk>, Eric Dumazet <edumazet@...gle.com>, Fabio Estevam <festevam@...il.com>, Jesper Dangaard Brouer <hawk@...nel.org>, John Fastabend <john.fastabend@...il.com>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "linux-stm32@...md-mailman.stormreply.com" <linux-stm32@...md-mailman.stormreply.com>, Maxime Coquelin <mcoquelin.stm32@...il.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, NXP Linux Team <linux-imx@....com>, Paolo Abeni <pabeni@...hat.com>, Pengutronix Kernel Team <kernel@...gutronix.de>, Samin Guo <samin.guo@...rfivetech.com>, Sascha Hauer <s.hauer@...gutronix.de>, Shawn Guo <shawnguo@...nel.org> Subject: Re: [PATCH net-next 4/6] net: stmmac: rk: use stmmac_set_tx_clk_gmii() Russel, Jose On Thu, Sep 14, 2023 at 04:01:41PM +0000, Jose Abreu wrote: > From: Russell King (Oracle) <linux@...linux.org.uk> > Date: Thu, Sep 14, 2023 at 16:30:11 > > > On Thu, Sep 14, 2023 at 04:27:19PM +0100, Russell King (Oracle) wrote: > > > I won't be doing that, sorry. If that's not acceptable, then I'm > > > junking this series. > > > > In fact, no, I'm making that decision now. I have 42 patches. I'm > > deleting them all because I just can't be bothered with the hassle > > of trying to improve this crappy driver. I am sorry to read that. In no means I intended to cause such reaction, but merely to improve the suggested changes as I see it. Speaking about the stmmac driver. I've got over _200_ cleanup, fix and feature patches in my local repo waiting for me having a free time to be properly prepared and finally submitted for review. So I totally understand your initial desire to improve the driver code. > > Hi Russell, Serge, Jakub, > > My apologies for not being that active on the review. I totally understand > there's a lot of revamps needed on "stmmac", somethings may even > need to be totally re-written. > > I'm also aware that Russell has contributed significantly for this process > and was of great help when we first switched "stmmac" to phylink. > > So, my 5-cents here is that, on this stage, any contribution on > "stmmac" is welcomed and we shouldn't try to ask for more > but focus instead on small steps. I actually thought the driver has been long abandoned seeing how many questionable changes have been accepted. That's why I decided to step in with more detailed reviews for now. Anyway It's up to you to decide. You are the driver maintainer after all. -Serge(y) > > Thanks, > Jose
Powered by blists - more mailing lists