netdev - RE: [PATCH net-next 4/6] net: stmmac: rk: use stmmac_set_tx_clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 15 Sep 2023 08:38:51 +0000
From: Jose Abreu <Jose.Abreu@...opsys.com>
To: Serge Semin <fancer.lancer@...il.com>,
        Russell King
	<linux@...linux.org.uk>
CC: Russell King <linux@...linux.org.uk>, Jakub Kicinski <kuba@...nel.org>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        Alexei Starovoitov <ast@...nel.org>,
        "bpf@...r.kernel.org" <bpf@...r.kernel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        "David S. Miller" <davem@...emloft.net>,
        Emil Renner Berthing <kernel@...il.dk>,
        Eric Dumazet <edumazet@...gle.com>, Fabio Estevam <festevam@...il.com>,
        Jesper Dangaard Brouer <hawk@...nel.org>,
        John Fastabend <john.fastabend@...il.com>,
        "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>,
        "linux-stm32@...md-mailman.stormreply.com" <linux-stm32@...md-mailman.stormreply.com>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        NXP Linux Team <linux-imx@....com>, Paolo Abeni <pabeni@...hat.com>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Samin Guo <samin.guo@...rfivetech.com>,
        Sascha Hauer <s.hauer@...gutronix.de>, Shawn Guo <shawnguo@...nel.org>,
        Jose Abreu <Jose.Abreu@...opsys.com>
Subject: RE: [PATCH net-next 4/6] net: stmmac: rk: use
 stmmac_set_tx_clk_gmii()

From: Serge Semin <fancer.lancer@...il.com>
Date: Thu, Sep 14, 2023 at 18:05:09

> I actually thought the driver has been long abandoned seeing how many
> questionable changes have been accepted. That's why I decided to step
> in with more detailed reviews for now. Anyway It's up to you to
> decide. You are the driver maintainer after all.

It's up to everyone to decide. I understand your comments on the patchset
and agree with most of them but on the topic of changing the entire
patchset to add the fix on "plat_stmmacenet_data->fix_mac_speed",
I don't think it's on the scope of this series.

Thanks,
Jose