lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <e3ed5c1e03d14dabb073bbb6d56f0fb825e770a4.camel@redhat.com> Date: Thu, 14 Sep 2023 11:02:05 +0200 From: Paolo Abeni <pabeni@...hat.com> To: Aananth V <aananthv@...gle.com>, David Miller <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org> Cc: netdev@...r.kernel.org, Neal Cardwell <ncardwell@...gle.com>, Yuchung Cheng <ycheng@...gle.com> Subject: Re: [PATCH net-next 2/2] tcp: new TCP_INFO stats for RTO events Hi, On Tue, 2023-09-12 at 02:33 +0000, Aananth V wrote: > @@ -2825,6 +2829,14 @@ void tcp_enter_recovery(struct sock *sk, bool ece_ack) > tcp_set_ca_state(sk, TCP_CA_Recovery); > } > > +static inline void tcp_update_rto_time(struct tcp_sock *tp) > +{ > + if (tp->rto_stamp) { > + tp->total_rto_time += tcp_time_stamp(tp) - tp->rto_stamp; > + tp->rto_stamp = 0; > + } > +} The CI is complaining about 'inline' function in .c file. I guess that is not by accident and the goal is to maximize fast-path performances? Perhaps worthy moving the function to an header file to make static checkers happy? Thanks! Paolo
Powered by blists - more mailing lists