netdev - Re: [PATCH net] amd-xgbe: read STAT1 register twice to get correct value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <13d692fb-1f89-4336-a53a-d5d07d81f6a6@lunn.ch>
Date: Sun, 17 Sep 2023 16:11:47 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Raju Rangoju <Raju.Rangoju@....com>
Cc: Tom Lendacky <thomas.lendacky@....com>, netdev@...r.kernel.org,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, Shyam-sundar.S-k@....com
Subject: Re: [PATCH net] amd-xgbe: read STAT1 register twice to get correct
 value

> Thanks, Tom.
> 
> The following thread (found online) has the detailed info on the IEEE 802.3
> Standard that define the Link Status bit:
> 
> https://microchip.my.site.com/s/article/How-to-correctly-read-the-Ethernet-PHY-Link-Status-bit

The relevant section for me is:

    Having a latched-low bit helps to ensure a link drop (no matter
    how short the duration before re-establishing link-up again) gets
    recorded and can be read from PHY register by the upper network
    layer (e.g., MAC processor).

By reading it twice, you are loosing the information the link went
down. This could mean you don't restart dhcp to get a new IP address
for a new subnet, kick of IPv6 getting the new network prefix so it
can create its IPv6 address etc.

When Linux is driving the PHYs using phylib, drivers are written such
that they report the latched link down. This gets report to the stack,
and so up to user space etc. phylib will then ask the driver a second
time to get the link status, and it might then return that the link is
now up. That then gets reported to the stack and user space.

As i said, you are not using phylib, this is not a linux PHY driver,
so i don't actually care what you do here. I just want to point out
why what you are doing could be wrong.

    Andrew