netdev - Re: [PATCH v15 05/20] nvme-tcp: Add DDP offload control path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <253a5tjhcc1.fsf@nvidia.com>
Date: Mon, 18 Sep 2023 15:53:34 +0300
From: Aurelien Aptel <aaptel@...dia.com>
To: Sagi Grimberg <sagi@...mberg.me>, linux-nvme@...ts.infradead.org,
 netdev@...r.kernel.org, hch@....de, kbusch@...nel.org, axboe@...com,
 chaitanyak@...dia.com, davem@...emloft.net, kuba@...nel.org
Cc: Boris Pismenny <borisp@...dia.com>, aurelien.aptel@...il.com,
 smalin@...dia.com, malin1024@...il.com, ogerlitz@...dia.com,
 yorayz@...dia.com, galshalom@...dia.com, mgurtovoy@...dia.com
Subject: Re: [PATCH v15 05/20] nvme-tcp: Add DDP offload control path


Sagi Grimberg <sagi@...mberg.me> writes:
> Perhaps you should bundle them together:
>         ctrl->ddp_netdev = nvme_tcp_get_ddp_netdev_with_limits(ctrl);
>         if (ctrl->ddp_netdev)
>                 nvme_tcp_ddp_apply_ctrl_limits(ctrl);
> [...]

Sure, we will rewrite it this way.

> 
> And perhaps its time to introduce nvme_tcp_stop_admin_queue()?
> static void nvme_tcp_stop_admin_queue(struct nvme_ctrl *nctrl) {
>         struct nvme_tcp_ctrl *ctrl = to_tcp_ctrl(nctrl);
> 
>         nvme_tcp_stop_queue(nctrl, 0);
>         dev_put(ctrl->ddp_netdev);
> }

Ok, we will add nvme_tcp_stop_admin_queue() and use it to replace calls
to nvme_tcp_stop_queue(ctrl, 0).

Thanks