netdev - Re: [PATCH net-next 1/7] net: phy: always call phy_process_state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b54eca90-93cb-40ed-8c18-23b196b4728b@lunn.ch>
Date: Mon, 18 Sep 2023 14:55:32 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Marek Szyprowski <m.szyprowski@...sung.com>
Cc: "Russell King (Oracle)" <rmk+kernel@...linux.org.uk>,
	Heiner Kallweit <hkallweit1@...il.com>, chenhao418@...wei.com,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Jijie Shao <shaojijie@...wei.com>,
	lanhao@...wei.com, liuyonglong@...wei.com, netdev@...r.kernel.org,
	Paolo Abeni <pabeni@...hat.com>, shenjian15@...wei.com,
	wangjie125@...wei.com, wangpeiyang1@...wei.com
Subject: Re: [PATCH net-next 1/7] net: phy: always call
 phy_process_state_change() under lock

> This probably need to be fixed somewhere in drivers/net/usb/asix* but at 
> the first glance I don't see any obvious place that need a fix.

static int __asix_mdio_read(struct net_device *netdev, int phy_id, int loc,
                            bool in_pm)
{
        struct usbnet *dev = netdev_priv(netdev);
        __le16 res;
        int ret;

        mutex_lock(&dev->phy_mutex);

Taking this lock here is the problem. Same for write.

There is some funky stuff going on in asix_devices.c. It using both
phylib and the much older mii code.

       Andrew