netdev - Re: [PATCH net-next 49/54] net: ethernet: ti: Convert to platform remove callback returning void

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 18 Sep 2023 13:54:28 -0700
From: Florian Fainelli <f.fainelli@...il.com>
To: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Cc: Grygorii Strashko <grygorii.strashko@...com>,
 Marc Kleine-Budde <mkl@...gutronix.de>, Nathan Chancellor
 <nathan@...nel.org>, Nathan Huckleberry <nhuck@...gle.com>,
 Geert Uytterhoeven <geert+renesas@...der.be>,
 Bhupesh Sharma <bhupesh.sharma@...aro.org>, Wei Fang <wei.fang@....com>,
 Andrew Lunn <andrew@...n.ch>, Rob Herring <robh@...nel.org>,
 Thomas Gleixner <tglx@...utronix.de>,
 Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
 Arnd Bergmann <arnd@...db.de>, netdev@...r.kernel.org,
 kernel@...gutronix.de, linux-omap@...r.kernel.org
Subject: Re: [PATCH net-next 49/54] net: ethernet: ti: Convert to platform
 remove callback returning void

On 9/18/23 13:42, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new() which already returns void. Eventually after all drivers
> are converted, .remove_new() is renamed to .remove().
> 
> Trivially convert these drivers from always returning zero in the remove
> callback to the void returning variant.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> ---
>   drivers/net/ethernet/ti/cpmac.c        | 6 ++----

Reviewed-by: Florian Fainelli <f.fainelli@...il.com> # cpmac
-- 
Florian