netdev - Re: [PATCH net-next 11/54] net: ethernet: broadcom: Convert to platform remove callback returning void

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e75eb4f1-84b5-d15b-5c2f-e2cfebbb7379@broadcom.com>
Date: Mon, 18 Sep 2023 13:55:17 -0700
From: Florian Fainelli <florian.fainelli@...adcom.com>
To: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Cc: Justin Chen <justin.chen@...adcom.com>, Rafał Miłecki
 <rafal@...ecki.pl>,
 Broadcom internal kernel review list
 <bcm-kernel-feedback-list@...adcom.com>, Doug Berger <opendmb@...il.com>,
 Li Zetao <lizetao1@...wei.com>, Steen Hegelund
 <Steen.Hegelund@...rochip.com>, Lukas Bulwahn <lukas.bulwahn@...il.com>,
 netdev@...r.kernel.org, kernel@...gutronix.de
Subject: Re: [PATCH net-next 11/54] net: ethernet: broadcom: Convert to
 platform remove callback returning void

On 9/18/23 13:41, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new() which already returns void. Eventually after all drivers
> are converted, .remove_new() is renamed to .remove().
> 
> Trivially convert these drivers from always returning zero in the remove
> callback to the void returning variant.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

Reviewed-by: Florian Fainelli <florian.fainelli@...adcom.com>
-- 
Florian

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4221 bytes)