netdev - Re: [PATCH net v2 2/3] net: prevent rewrite of msg_name in sock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAF=yD-J6YNpsbZvaoqZ=u1Do65ej35wRZeZ+4Dwwx-hv+zwrog@mail.gmail.com>
Date: Mon, 18 Sep 2023 17:25:27 -0400
From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
To: Jordan Rife <jrife@...gle.com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, 
	pabeni@...hat.com, netdev@...r.kernel.org, dborkman@...nel.org
Subject: Re: [PATCH net v2 2/3] net: prevent rewrite of msg_name in sock_sendmsg()

On Mon, Sep 18, 2023 at 4:49 PM Jordan Rife <jrife@...gle.com> wrote:
>
> Just a heads up, there are also kernel_recvmsg/sock_recvmsg functions
> that mirror the kernel_sendmsg/sock_sendmsg. If we are are doing this
>
> > 1) Rename the current kernel_sendmsg() function to
> > kernel_sendmsg_kvec() and name  our new function kernel_sendmsg(). To
> > me this makes some sense, considering the new function is the more
> > generic of the two, and the existing kernel_sendmsg() specifically
> > accepts "struct kvec".
>
> it creates an asymmetry between *sendmsg and *recvmsg function names.
> If we wanted these to be similar then it means a rename to these
> functions (e.g. kern_recvmsg becomes kern_recvmsg_kvec, rename
> sock_recvmsg to kern_recvmsg).

I see. That's definitely outside the realm of bug fix.

If we have to keep the two consistent, then I suppose your existing
fix is the best approach for net. And any renaming to clarify the API
is best left for net-next.