netdev - Re: [PATCH wpan-next v3 11/11] ieee802154: Give the user the association list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202309191044.4ABvPP5X-lkp@intel.com>
Date: Tue, 19 Sep 2023 11:10:44 +0800
From: kernel test robot <lkp@...el.com>
To: Miquel Raynal <miquel.raynal@...tlin.com>,
	Alexander Aring <alex.aring@...il.com>,
	Stefan Schmidt <stefan@...enfreihafen.org>,
	linux-wpan@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev, Jakub Kicinski <kuba@...nel.org>,
	Paolo Abeni <pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>,
	netdev@...r.kernel.org, David Girault <david.girault@...vo.com>,
	Romuald Despres <romuald.despres@...vo.com>,
	Frederic Blain <frederic.blain@...vo.com>,
	Nicolas Schodet <nico@...fr.eu.org>,
	Guilhem Imberton <guilhem.imberton@...vo.com>,
	Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
	Miquel Raynal <miquel.raynal@...tlin.com>
Subject: Re: [PATCH wpan-next v3 11/11] ieee802154: Give the user the
 association list

Hi Miquel,

kernel test robot noticed the following build errors:

[auto build test ERROR on net-next/main]
[also build test ERROR on net/main linus/master v6.6-rc2 next-20230918]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Miquel-Raynal/ieee802154-Let-PAN-IDs-be-reset/20230919-002634
base:   net-next/main
patch link:    https://lore.kernel.org/r/20230918150809.275058-12-miquel.raynal%40bootlin.com
patch subject: [PATCH wpan-next v3 11/11] ieee802154: Give the user the association list
config: powerpc64-randconfig-001-20230919 (https://download.01.org/0day-ci/archive/20230919/202309191044.4ABvPP5X-lkp@intel.com/config)
compiler: powerpc64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230919/202309191044.4ABvPP5X-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309191044.4ABvPP5X-lkp@intel.com/

All errors (new ones prefixed by >>):

   net/ieee802154/nl802154.c: In function 'nl802154_list_associations':
>> net/ieee802154/nl802154.c:1778:15: error: implicit declaration of function 'nl802154_prepare_wpan_dev_dump' [-Werror=implicit-function-declaration]
    1778 |         err = nl802154_prepare_wpan_dev_dump(skb, cb, &rdev, &wpan_dev);
         |               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> net/ieee802154/nl802154.c:1811:9: error: implicit declaration of function 'nl802154_finish_wpan_dev_dump' [-Werror=implicit-function-declaration]
    1811 |         nl802154_finish_wpan_dev_dump(rdev);
         |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors


vim +/nl802154_prepare_wpan_dev_dump +1778 net/ieee802154/nl802154.c

  1769	
  1770	static int nl802154_list_associations(struct sk_buff *skb,
  1771					      struct netlink_callback *cb)
  1772	{
  1773		struct cfg802154_registered_device *rdev;
  1774		struct ieee802154_pan_device *child;
  1775		struct wpan_dev *wpan_dev;
  1776		int err;
  1777	
> 1778		err = nl802154_prepare_wpan_dev_dump(skb, cb, &rdev, &wpan_dev);
  1779		if (err)
  1780			return err;
  1781	
  1782		mutex_lock(&wpan_dev->association_lock);
  1783	
  1784		if (cb->args[2])
  1785			goto out;
  1786	
  1787		if (wpan_dev->parent) {
  1788			err = nl802154_send_peer_info(skb, cb, cb->nlh->nlmsg_seq,
  1789						      NLM_F_MULTI, rdev, wpan_dev,
  1790						      wpan_dev->parent,
  1791						      NL802154_PEER_TYPE_PARENT);
  1792			if (err < 0)
  1793				goto out_err;
  1794		}
  1795	
  1796		list_for_each_entry(child, &wpan_dev->children, node) {
  1797			err = nl802154_send_peer_info(skb, cb, cb->nlh->nlmsg_seq,
  1798						      NLM_F_MULTI, rdev, wpan_dev,
  1799						      child,
  1800						      NL802154_PEER_TYPE_CHILD);
  1801			if (err < 0)
  1802				goto out_err;
  1803		}
  1804	
  1805		cb->args[2] = 1;
  1806	out:
  1807		err = skb->len;
  1808	out_err:
  1809		mutex_unlock(&wpan_dev->association_lock);
  1810	
> 1811		nl802154_finish_wpan_dev_dump(rdev);
  1812	
  1813		return err;
  1814	}
  1815	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki