netdev - Re: [PATCH wpan-next v3 11/11] ieee802154: Give the user the association list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230919093243.3e5f3429@xps-13>
Date: Tue, 19 Sep 2023 09:32:43 +0200
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: kernel test robot <lkp@...el.com>
Cc: Alexander Aring <alex.aring@...il.com>, Stefan Schmidt
 <stefan@...enfreihafen.org>, linux-wpan@...r.kernel.org,
 oe-kbuild-all@...ts.linux.dev, Jakub Kicinski <kuba@...nel.org>, Paolo
 Abeni <pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>,
 netdev@...r.kernel.org, David Girault <david.girault@...vo.com>, Romuald
 Despres <romuald.despres@...vo.com>, Frederic Blain
 <frederic.blain@...vo.com>, Nicolas Schodet <nico@...fr.eu.org>, Guilhem
 Imberton <guilhem.imberton@...vo.com>, Thomas Petazzoni
 <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH wpan-next v3 11/11] ieee802154: Give the user the
 association list

Hello,

>    net/ieee802154/nl802154.c: In function 'nl802154_list_associations':
> >> net/ieee802154/nl802154.c:1778:15: error: implicit declaration of function 'nl802154_prepare_wpan_dev_dump' [-Werror=implicit-function-declaration]  
>     1778 |         err = nl802154_prepare_wpan_dev_dump(skb, cb, &rdev, &wpan_dev);
>          |               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >> net/ieee802154/nl802154.c:1811:9: error: implicit declaration of function 'nl802154_finish_wpan_dev_dump' [-Werror=implicit-function-declaration]  
>     1811 |         nl802154_finish_wpan_dev_dump(rdev);
>          |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    cc1: some warnings being treated as errors
> 
> 
> vim +/nl802154_prepare_wpan_dev_dump +1778 net/ieee802154/nl802154.c
> 
>   1769	
>   1770	static int nl802154_list_associations(struct sk_buff *skb,
>   1771					      struct netlink_callback *cb)
>   1772	{
>   1773		struct cfg802154_registered_device *rdev;
>   1774		struct ieee802154_pan_device *child;
>   1775		struct wpan_dev *wpan_dev;
>   1776		int err;
>   1777	
> > 1778		err = nl802154_prepare_wpan_dev_dump(skb, cb, &rdev, &wpan_dev);  

[...]

> > 1811		nl802154_finish_wpan_dev_dump(rdev);  

These two are defined within #ifdef EXPERIMENTAL. I will move them out
as I need them as well inthe !EXPERIMENTAL case. Good that kernel test
robot eventually catch that.

Thanks,
Miquèl