[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <c436e4f0-1cfa-de9a-ca76-6f6aa0a5bfc3@tuxon.dev>
Date: Tue, 19 Sep 2023 09:00:39 +0300
From: claudiu beznea <claudiu.beznea@...on.dev>
To: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Cc: Nicolas Ferre <nicolas.ferre@...rochip.com>,
Russell King <linux@...linux.org.uk>, netdev@...r.kernel.org,
kernel@...gutronix.de
Subject: Re: [PATCH net-next 12/54] net: ethernet: cadence: Convert to
platform remove callback returning void
On 18.09.2023 23:41, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new() which already returns void. Eventually after all drivers
> are converted, .remove_new() is renamed to .remove().
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
Reviewed-by: Claudiu Beznea <claudiu.beznea@...on.dev>
> ---
> drivers/net/ethernet/cadence/macb_main.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
> index b940dcd3ace6..cebae0f418f2 100644
> --- a/drivers/net/ethernet/cadence/macb_main.c
> +++ b/drivers/net/ethernet/cadence/macb_main.c
> @@ -5156,7 +5156,7 @@ static int macb_probe(struct platform_device *pdev)
> return err;
> }
>
> -static int macb_remove(struct platform_device *pdev)
> +static void macb_remove(struct platform_device *pdev)
> {
> struct net_device *dev;
> struct macb *bp;
> @@ -5181,8 +5181,6 @@ static int macb_remove(struct platform_device *pdev)
> phylink_destroy(bp->phylink);
> free_netdev(dev);
> }
> -
> - return 0;
> }
>
> static int __maybe_unused macb_suspend(struct device *dev)
> @@ -5398,7 +5396,7 @@ static const struct dev_pm_ops macb_pm_ops = {
>
> static struct platform_driver macb_driver = {
> .probe = macb_probe,
> - .remove = macb_remove,
> + .remove_new = macb_remove,
> .driver = {
> .name = "macb",
> .of_match_table = of_match_ptr(macb_dt_ids),
Powered by blists - more mailing lists