netdev - Re: [PATCH net-next 41/54] net: ethernet: renesas: Convert to platform remove callback returning void

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdWuq+=Ss1zgD-9-sAd32Fjz5zYjMYStay6gGDW7YdCi9A@mail.gmail.com>
Date: Tue, 19 Sep 2023 08:58:38 +0200
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Sergey Shtylyov <s.shtylyov@....ru>, 
	Geert Uytterhoeven <geert+renesas@...der.be>, 
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>, Simon Horman <horms@...nel.org>, 
	Wolfram Sang <wsa+renesas@...g-engineering.com>, Biju Das <biju.das.jz@...renesas.com>, 
	Alexander Duyck <alexanderduyck@...com>, Michael Walle <michael@...le.cc>, Rob Herring <robh@...nel.org>, 
	Andrew Lunn <andrew@...n.ch>, netdev@...r.kernel.org, linux-renesas-soc@...r.kernel.org, 
	kernel@...gutronix.de
Subject: Re: [PATCH net-next 41/54] net: ethernet: renesas: Convert to
 platform remove callback returning void

On Mon, Sep 18, 2023 at 10:42 PM Uwe Kleine-König
<u.kleine-koenig@...gutronix.de> wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new() which already returns void. Eventually after all drivers
> are converted, .remove_new() is renamed to .remove().
>
> Trivially convert these drivers from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds