netdev - Re: [PATCH net v4 3/3] net: prevent address rewrite in kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <650af4001eb7c_37ac7329443@willemb.c.googlers.com.notmuch>
Date: Wed, 20 Sep 2023 09:30:40 -0400
From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
To: Jordan Rife <jrife@...gle.com>, 
 davem@...emloft.net, 
 edumazet@...gle.com, 
 kuba@...nel.org, 
 pabeni@...hat.com, 
 willemdebruijn.kernel@...il.com, 
 netdev@...r.kernel.org
Cc: dborkman@...nel.org, 
 philipp.reisner@...bit.com, 
 lars.ellenberg@...bit.com, 
 christoph.boehmwalder@...bit.com, 
 axboe@...nel.dk, 
 airlied@...hat.com, 
 chengyou@...ux.alibaba.com, 
 kaishen@...ux.alibaba.com, 
 jgg@...pe.ca, 
 leon@...nel.org, 
 bmt@...ich.ibm.com, 
 isdn@...ux-pingi.de, 
 ccaulfie@...hat.com, 
 teigland@...hat.com, 
 mark@...heh.com, 
 jlbec@...lplan.org, 
 joseph.qi@...ux.alibaba.com, 
 sfrench@...ba.org, 
 pc@...guebit.com, 
 lsahlber@...hat.com, 
 sprasad@...rosoft.com, 
 tom@...pey.com, 
 horms@...ge.net.au, 
 ja@....bg, 
 pablo@...filter.org, 
 kadlec@...filter.org, 
 fw@...len.de, 
 santosh.shilimkar@...cle.com, 
 Jordan Rife <jrife@...gle.com>, 
 stable@...r.kernel.org
Subject: Re: [PATCH net v4 3/3] net: prevent address rewrite in kernel_bind()

Jordan Rife wrote:
> Similar to the change in commit 0bdf399342c5("net: Avoid address
> overwrite in kernel_connect"), BPF hooks run on bind may rewrite the
> address passed to kernel_bind(). This change
> 
> 1) Makes a copy of the bind address in kernel_bind() to insulate
>    callers.
> 2) Replaces direct calls to sock->ops->bind() with kernel_bind()
> 
> Link: https://lore.kernel.org/netdev/20230912013332.2048422-1-jrife@google.com/
> Fixes: 4fbac77d2d09 ("bpf: Hooks for sys_bind")
> Cc: stable@...r.kernel.org
> Signed-off-by: Jordan Rife <jrife@...gle.com>

Reviewed-by: Willem de Bruijn <willemb@...gle.com>