netdev - Re: [PATCH net v4 3/3] net: prevent address rewrite in kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 21 Sep 2023 10:35:25 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Willem de Bruijn <willemdebruijn.kernel@...il.com>, Jordan Rife
 <jrife@...gle.com>, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org,  netdev@...r.kernel.org
Cc: dborkman@...nel.org, philipp.reisner@...bit.com,
 lars.ellenberg@...bit.com,  christoph.boehmwalder@...bit.com,
 axboe@...nel.dk, airlied@...hat.com,  chengyou@...ux.alibaba.com,
 kaishen@...ux.alibaba.com, jgg@...pe.ca,  leon@...nel.org,
 bmt@...ich.ibm.com, isdn@...ux-pingi.de, ccaulfie@...hat.com, 
 teigland@...hat.com, mark@...heh.com, jlbec@...lplan.org, 
 joseph.qi@...ux.alibaba.com, sfrench@...ba.org, pc@...guebit.com, 
 lsahlber@...hat.com, sprasad@...rosoft.com, tom@...pey.com,
 horms@...ge.net.au,  ja@....bg, pablo@...filter.org, kadlec@...filter.org,
 fw@...len.de,  santosh.shilimkar@...cle.com, stable@...r.kernel.org
Subject: Re: [PATCH net v4 3/3] net: prevent address rewrite in kernel_bind()

On Wed, 2023-09-20 at 09:30 -0400, Willem de Bruijn wrote:
> Jordan Rife wrote:
> > Similar to the change in commit 0bdf399342c5("net: Avoid address
> > overwrite in kernel_connect"), BPF hooks run on bind may rewrite the
> > address passed to kernel_bind(). This change
> > 
> > 1) Makes a copy of the bind address in kernel_bind() to insulate
> >    callers.
> > 2) Replaces direct calls to sock->ops->bind() with kernel_bind()
> > 
> > Link: https://lore.kernel.org/netdev/20230912013332.2048422-1-jrife@google.com/
> > Fixes: 4fbac77d2d09 ("bpf: Hooks for sys_bind")
> > Cc: stable@...r.kernel.org
> > Signed-off-by: Jordan Rife <jrife@...gle.com>
> 
> Reviewed-by: Willem de Bruijn <willemb@...gle.com>

I fear this is going to cause a few conflicts with other trees. We can
still take it, but at very least we will need some acks from the
relevant maintainers.

I *think* it would be easier split this and patch 1/3 in individual
patches targeting the different trees, hopefully not many additional
patches will be required. What do you think?

Cheers,

Paolo