netdev - Re: [PATCH net] neighbour: fix data-races around n->output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <121d8e5b-1471-6252-219b-6ec4abf872f0@kernel.org>
Date: Thu, 21 Sep 2023 13:37:59 -0600
From: David Ahern <dsahern@...nel.org>
To: Eric Dumazet <edumazet@...gle.com>, "David S . Miller"
 <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>
Cc: netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH net] neighbour: fix data-races around n->output

On 9/21/23 3:27 AM, Eric Dumazet wrote:
> n->output field can be read locklessly, while a writer
> might change the pointer concurrently.
> 
> Add missing annotations to prevent load-store tearing.
> 
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> ---
>  include/net/neighbour.h         |  2 +-
>  net/bridge/br_netfilter_hooks.c |  2 +-
>  net/core/neighbour.c            | 10 +++++-----
>  3 files changed, 7 insertions(+), 7 deletions(-)
> 

Reviewed-by: David Ahern <dsahern@...nel.org>

WRITE_ONCE is needed for net/atm/clip.c