netdev - Re: [PATCH net] neighbour: fix data-races around n->output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iL0qUDk8j02zdMFVxof+a4kxFAdxDSe42Gmx405=V4=fA@mail.gmail.com>
Date: Thu, 21 Sep 2023 21:56:20 +0200
From: Eric Dumazet <edumazet@...gle.com>
To: David Ahern <dsahern@...nel.org>
Cc: "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH net] neighbour: fix data-races around n->output

On Thu, Sep 21, 2023 at 9:38 PM David Ahern <dsahern@...nel.org> wrote:
>
> On 9/21/23 3:27 AM, Eric Dumazet wrote:
> > n->output field can be read locklessly, while a writer
> > might change the pointer concurrently.
> >
> > Add missing annotations to prevent load-store tearing.
> >
> > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> > Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> > ---
> >  include/net/neighbour.h         |  2 +-
> >  net/bridge/br_netfilter_hooks.c |  2 +-
> >  net/core/neighbour.c            | 10 +++++-----
> >  3 files changed, 7 insertions(+), 7 deletions(-)
> >
>
> Reviewed-by: David Ahern <dsahern@...nel.org>
>
>
> WRITE_ONCE is needed for net/atm/clip.c

Like other constructors (ipv4, ipv6), clip_constructor() is called on
a not yet published object,
no particular burier is needed.

Thanks.