netdev - RE: [PATCH net-next 3/3] tcp: derive delack_max from rto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <26be5679fdae405f9a932bfc3f28c203@AcuMS.aculab.com>
Date: Fri, 22 Sep 2023 09:59:41 +0000
From: David Laight <David.Laight@...LAB.COM>
To: 'Eric Dumazet' <edumazet@...gle.com>, David Ahern <dsahern@...nel.org>
CC: "David S . Miller" <davem@...emloft.net>, Jakub Kicinski
	<kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Soheil Hassas Yeganeh
	<soheil@...gle.com>, Neal Cardwell <ncardwell@...gle.com>, Yuchung Cheng
	<ycheng@...gle.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"eric.dumazet@...il.com" <eric.dumazet@...il.com>
Subject: RE: [PATCH net-next 3/3] tcp: derive delack_max from rto_min

From: Eric Dumazet
> Sent: 21 September 2023 13:58
> 
> On Thu, Sep 21, 2023 at 2:37 PM David Ahern <dsahern@...nel.org> wrote:
> >
> 
> > My comment is solely about mismatch on data types. I am surprised use of
> > max_t with mixed data types does not throw a compiler warning.
> 
> This was intentional.
> 
> This is max_t() purpose really.

Apart from when it gets used to accidentally mask high bits :-)
(Although hat is usually consigned to min_t()).

Here
	u32 delack_from_rto_min = max(rto_min, 2u) - 1;
would probably be safer (as in have no casts that might have
unwanted side effects).

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)