netdev - Re: [PATCH net v5 1/3] net: replace calls to sock->ops->connect() with kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230927055033.GB224399@kernel.org>
Date: Wed, 27 Sep 2023 07:50:33 +0200
From: Simon Horman <horms@...nel.org>
To: Jordan Rife <jrife@...gle.com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, willemdebruijn.kernel@...il.com,
	netdev@...r.kernel.org, dborkman@...nel.org, pablo@...filter.org,
	kadlec@...filter.org, fw@...len.de, santosh.shilimkar@...cle.com,
	ast@...nel.org, rdna@...com, stable@...r.kernel.org,
	Willem de Bruijn <willemb@...gle.com>
Subject: Re: [PATCH net v5 1/3] net: replace calls to sock->ops->connect()
 with kernel_connect()

On Thu, Sep 21, 2023 at 06:46:40PM -0500, Jordan Rife wrote:
> commit 0bdf399342c5 ("net: Avoid address overwrite in kernel_connect")
> ensured that kernel_connect() will not overwrite the address parameter
> in cases where BPF connect hooks perform an address rewrite. This change
> replaces direct calls to sock->ops->connect() in net with kernel_connect()
> to make these call safe.
> 
> Link: https://lore.kernel.org/netdev/20230912013332.2048422-1-jrife@google.com/
> Fixes: d74bad4e74ee ("bpf: Hooks for sys_connect")
> Cc: stable@...r.kernel.org
> Reviewed-by: Willem de Bruijn <willemb@...gle.com>
> Signed-off-by: Jordan Rife <jrife@...gle.com>

Reviewed-by: Simon Horman <horms@...nel.org>