netdev - Re: [PATCH net v5 3/3] net: prevent address rewrite in kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230927055126.GD224399@kernel.org>
Date: Wed, 27 Sep 2023 07:51:26 +0200
From: Simon Horman <horms@...nel.org>
To: Jordan Rife <jrife@...gle.com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, willemdebruijn.kernel@...il.com,
	netdev@...r.kernel.org, dborkman@...nel.org, pablo@...filter.org,
	kadlec@...filter.org, fw@...len.de, santosh.shilimkar@...cle.com,
	ast@...nel.org, rdna@...com, stable@...r.kernel.org,
	Willem de Bruijn <willemb@...gle.com>
Subject: Re: [PATCH net v5 3/3] net: prevent address rewrite in kernel_bind()

On Thu, Sep 21, 2023 at 06:46:42PM -0500, Jordan Rife wrote:
> Similar to the change in commit 0bdf399342c5("net: Avoid address
> overwrite in kernel_connect"), BPF hooks run on bind may rewrite the
> address passed to kernel_bind(). This change
> 
> 1) Makes a copy of the bind address in kernel_bind() to insulate
>    callers.
> 2) Replaces direct calls to sock->ops->bind() in net with kernel_bind()
> 
> Link: https://lore.kernel.org/netdev/20230912013332.2048422-1-jrife@google.com/
> Fixes: 4fbac77d2d09 ("bpf: Hooks for sys_bind")
> Cc: stable@...r.kernel.org
> Reviewed-by: Willem de Bruijn <willemb@...gle.com>
> Signed-off-by: Jordan Rife <jrife@...gle.com>

Reviewed-by: Simon Horman <horms@...nel.org>