netdev - Re: [patch net-next] tools: ynl-gen: lift type requirement for attribute subsets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ffeeac4ea45e5a087aab44ac137a945111d941e7.camel@redhat.com>
Date: Thu, 28 Sep 2023 12:15:22 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Jiri Pirko <jiri@...nulli.us>, netdev@...r.kernel.org
Cc: kuba@...nel.org, davem@...emloft.net, edumazet@...gle.com
Subject: Re: [patch net-next] tools: ynl-gen: lift type requirement for
 attribute subsets

On Tue, 2023-09-19 at 16:21 +0200, Jiri Pirko wrote:
> From: Jiri Pirko <jiri@...dia.com>
> 
> In case an attribute is used in a subset, the type has to be currently
> specified. As the attribute is already defined in the original set, this
> is a redundant information in yaml file, moreover, may lead to
> inconsistencies.
> 
> Example:
> attribute-sets:
>     ...
>     name: pin
>     enum-name: dpll_a_pin
>     attributes:
>       ...
>       -
>         name: parent-id
>         type: u32
>       ...
>   -
>     name: pin-parent-device
>     subset-of: pin
>     attributes:
>       -
>         name: parent-id
>         type: u32             <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
> 
> Remove the requirement from schema files to specify the "type" and add
> check and bail out if "type" is not set.
> 
> Signed-off-by: Jiri Pirko <jiri@...dia.com>

What about updating accordingly the existing specs? They are used as
references, I think it would be better if the info there would be
consistent.

I think the tool still allows writing something alike:

    attributes:
      ...
      -
        name: parent-id
        type: u32
      ...
  -
    name: pin-parent-device
    subset-of: pin
    attributes:
      -
        name: parent-id
        type: string

(mismatching types). What about adding an explicit test to prevent
specifying again the types for already defined attributes?

Cheers,

Paolo