netdev - Re: [PATCH net, 1/3] net: mana: Fix TX CQE error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230929055030.GS24230@kernel.org>
Date: Fri, 29 Sep 2023 07:50:30 +0200
From: Simon Horman <horms@...nel.org>
To: Haiyang Zhang <haiyangz@...rosoft.com>
Cc: linux-hyperv@...r.kernel.org, netdev@...r.kernel.org,
	decui@...rosoft.com, kys@...rosoft.com, paulros@...rosoft.com,
	olaf@...fle.de, vkuznets@...hat.com, davem@...emloft.net,
	wei.liu@...nel.org, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, leon@...nel.org, longli@...rosoft.com,
	ssengar@...ux.microsoft.com, linux-rdma@...r.kernel.org,
	daniel@...earbox.net, john.fastabend@...il.com, bpf@...r.kernel.org,
	ast@...nel.org, sharmaajay@...rosoft.com, hawk@...nel.org,
	tglx@...utronix.de, shradhagupta@...ux.microsoft.com,
	linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH net, 1/3] net: mana: Fix TX CQE error handling

On Fri, Sep 29, 2023 at 07:47:57AM +0200, Simon Horman wrote:
> On Sat, Sep 23, 2023 at 06:31:45PM -0700, Haiyang Zhang wrote:
> > For an unknown TX CQE error type (probably from a newer hardware),
> > still free the SKB, update the queue tail, etc., otherwise the
> > accounting will be wrong.
> > 
> > Also, TX errors can be triggered by injecting corrupted packets, so
> > replace the WARN_ONCE to ratelimited error logging, because we don't
> > need stack trace here.
> > 
> > Cc: stable@...r.kernel.org
> > Fixes: ca9c54d2d6a5 ("net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)")
> > Signed-off-by: Haiyang Zhang <haiyangz@...rosoft.com>
> 
> Reviewed-by: Simon Horman <horms@...nel.org>

Sorry, one latent question.

The patch replaces WARN_ONCE with a net_ratelimit()'d netdev_err().
But I do wonder if, as a fix, netdev_err_once() would be more appropriate.