netdev - Re: [PATCH v2 1/2] net: page_pool: check page pool ethtool stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231002124650.7f01e1e6@kernel.org>
Date: Mon, 2 Oct 2023 12:46:50 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Sven Auhagen <sven.auhagen@...eatech.de>
Cc: netdev@...r.kernel.org, thomas.petazzoni@...tlin.com, hawk@...nel.org,
 lorenzo@...nel.org, Paulo.DaSilva@...erna.com, ilias.apalodimas@...aro.org,
 mcroce@...ux.microsoft.com
Subject: Re: [PATCH v2 1/2] net: page_pool: check page pool ethtool stats

On Sun, 1 Oct 2023 13:41:15 +0200 Sven Auhagen wrote:
> If the page_pool variable is null while passing it to
> the page_pool_get_stats function we receive a kernel error.
> 
> Check if the page_pool variable is at least valid.

IMHO this seems insufficient, the driver still has to check if PP 
was instantiated when the strings are queried. My weak preference
would be to stick to v1 and have the driver check all the conditions.
But if nobody else feels this way, it's fine :)