netdev - Re: [PATCH v2 1/2] net: page_pool: check page pool ethtool stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <wt6tkw6g5ouhjcs3mqdibzoveczfqmnolpdzxaiapfbs7buoom@lvfwkxjk6bj7>
Date: Tue, 3 Oct 2023 06:12:25 +0200
From: Sven Auhagen <sven.auhagen@...eatech.de>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, thomas.petazzoni@...tlin.com, hawk@...nel.org, 
	lorenzo@...nel.org, Paulo.DaSilva@...erna.com, ilias.apalodimas@...aro.org, 
	mcroce@...ux.microsoft.com
Subject: Re: [PATCH v2 1/2] net: page_pool: check page pool ethtool stats

On Mon, Oct 02, 2023 at 12:46:50PM -0700, Jakub Kicinski wrote:
> On Sun, 1 Oct 2023 13:41:15 +0200 Sven Auhagen wrote:
> > If the page_pool variable is null while passing it to
> > the page_pool_get_stats function we receive a kernel error.
> > 
> > Check if the page_pool variable is at least valid.
> 
> IMHO this seems insufficient, the driver still has to check if PP 
> was instantiated when the strings are queried. My weak preference
> would be to stick to v1 and have the driver check all the conditions.
> But if nobody else feels this way, it's fine :)

:) let me know which variant is preferred so I can send a new
v3.